fix: custom bounds and p0 will be ignored if fitting is triggered by property getters. #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, the custom
boundsandp0stored inself._kwargsare only used whenself.fit()is called in__init__():scikit-gstat/skgstat/Variogram.py
Lines 392 to 394 in 46bc79e
But not in some property getters, for example in
transform():scikit-gstat/skgstat/Variogram.py
Lines 1809 to 1810 in 46bc79e
or in
describe():scikit-gstat/skgstat/Variogram.py
Lines 2611 to 2612 in 46bc79e
etc.
Considering this, I suggest getting custom
boundsandp0withinfit().