Skip to content

Conversation

@fncokg
Copy link

@fncokg fncokg commented Aug 14, 2025

In the current code, the custom bounds and p0 stored in self._kwargs are only used when self.fit() is called in __init__():

fit_bounds = self._kwargs.get('fit_bounds') # returns None if empty
fit_p0 = self._kwargs.get('fit_p0')
self.fit(force=True, bounds=fit_bounds, p0=fit_p0)

But not in some property getters, for example in transform():

if self.cof is None:
self.fit(force=True)

or in describe():

if self.cof is None:
self.fit(force=True)

etc.

Considering this, I suggest getting custom bounds and p0 within fit().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant