Enhance maxlag handling with max_dist parameter and estimation for relative maxlag #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaelicke
changed the title
…lative maxlag - Add max_dist parameter to Variogram.__init__ for explicit distance limiting - Implement estimation for relative maxlag using random samples with warning - Update docstring and add test for warning - Ensure consistent experimental variograms for equivalent maxlag values - Limit distance computation for performance on large datasets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix inconsistent MetricSpace instantiation in Variogram for different maxlag settings. Previously, absolute maxlag (>=1) created sparse MetricSpace, while relative maxlag (<1) created dense, leading to different distance calculations and incorrect plots/binning.
Changes
Variogram.__init__to always create MetricSpace withmax_dist=Nonefor consistent dense distance matrices.test_sparse_maxlag_30to reflect improved accuracy.maxlagdocstring with examples, including pre-computed MetricSpace usage.Impact
All tests pass, no regressions.