Conversation
mmastrac
changed the title
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Oct 7, 2025
### What Update `ctor` dependency from `0.2.9` to `0.5.0`. ### Why It was reported in #1582 that undefined behaviour was detected by Miri. The undefined behaviour was in the `ctor` crate, but was fixed in mmastrac/rust-ctor#343 which was released in `ctor` `0.5.0`. ### Note I tried adding miri to CI, but it takes too long, more than an hour. I've left the makefile target for running miri for future convenience. Fix #1582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #341 points out UB reported by miri.
We don't need a zero return from ctor functions on platforms other than Windows.