Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify a comment w.r.t. empty slice #571

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 4, 2025

Hi !

I'm reading through gobyexample these days as I'm learning Go, and I came across 2 things:

  • i think there were forgotten go keywords for calling routines.
  • i wanted to suggest a slight text adjustment, which I had a bit of hard understanding at first. I think when creating a slice like s = make([]string, 3), the slice is not empty, it contains 3 elements, the only thing is those elements are zero-valued but still the slice is not empty. I just thought it was a bit confusing when I read that, I had to read several times and then test it to really make sure I understood. So, here is a very little adjustment.

Let me know what you think! :)

@eliben eliben changed the title fix: Added go for routines - Correct doc clarify a comment w.r.t. empty slice Feb 7, 2025
@eliben
Copy link
Collaborator

eliben commented Feb 7, 2025

Thanks for the adjustment.

Would you mind running tools/build in the root directory and adding the generated file to the PR? This will enable me to just merge it directly without fixups

(https://github.com/mmcgrana/gobyexample/blob/master/CONTRIBUTING.md)

@hudem1
Copy link
Contributor Author

hudem1 commented Feb 8, 2025

Thanks for the adjustment.

Would you mind running tools/build in the root directory and adding the generated file to the PR? This will enable me to just merge it directly without fixups

(https://github.com/mmcgrana/gobyexample/blob/master/CONTRIBUTING.md)

Oops, sorry forgot to do that! Just done :)

@eliben eliben merged commit a0afe45 into mmcgrana:master Feb 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants