-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: reproduce nested sql bug #439
base: pgkit
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ah, I see! this is a clever fix, I will test it out a bit later |
hi, @mmkal , I've tested other cases and it works fine. but I have another question here, regarding the MemberType: pgkit/packages/client/src/types.ts Line 83 in 25b578f
it generated code: $2::text[], however, there are other types in the pg. such as:
which end up with:
is this what you think can be added? |
see: #440 |
Re: #438
@caoer first commit 46880bc just adds a test which will fail - this is the bug you found. Second commit will be a fix.
Update: failed as expected, see screenshot below.
Fix in 16d94c2 - haven't run the full suite but let's see.