If available, GearmanParser should use the getProjectDir() method #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Kernel to set its rootDir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Encountered
I'm using Symfony 4.4 and mmoreram/gearman-bundle (5.1.1).
In my project, Kernel.php is not located in the default /src folder.
However, GearmanParser determines its rootDir based on the assumed location of Kernel.php, which is incorrect in my case.
Proposed Solution
If available, GearmanParser should use the getProjectDir() method from Kernel to set its rootDir instead of relying on hardcoded paths.