core/parser: remove used members and parameters.#295
Open
wathiede wants to merge 2 commits intommp:masterfrom
Open
core/parser: remove used members and parameters.#295wathiede wants to merge 2 commits intommp:masterfrom
wathiede wants to merge 2 commits intommp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would appear the
SpectrumTypeisn't used anywhere in the new hand-rolled parser. As a reader, I found it confusing that it is set to different values, but not used. Are they supposed to be used? If no, please consider this pull request to remove them.Additionally I removed the
isStringmember onParamListItem. I think it is vestigial, as you end up checking ifitem.stringValuesoritem.doubleValueswas set inAddParamas an alternative to determining if the parameter is a string.