Handle conditional PPPs (iseq) #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a previously registered PPP is no longer a PPP when a GC starts, we don't pin its children, and we remove it from the list of PPPs. Currently only iseq is conditional PPP.
|
I reverted this PR because it contains bugs that somehow slipped through CI tests. I'll work on this optimization again later based on the code in #83. |
This was referenced Jul 9, 2024
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Aug 22, 2024
The Ruby repository cherry-picked mmtk/ruby#80 onto the dev/mmtk-overrides-default branch which will follow the official master branch. It added CI scripts and excluded some tests using Ruby scripts in the `.excludes-mmtk/` directory. With this change, it should be, in theory, possible to selectively run tests runnable for MMTk without using the whitelist `ruby-test-cases.txt` in this repo. However, some test cases still crashes due to bugs in the binding. We'll still use the whitelist for running binding tests for the mmtk-core repo, until we fix those crashes so that `make test-all` can finish safely with MMTk enabled. For this reason, we are not changing the CI scripts in this repository.
wks
added a commit
to wks/mmtk-ruby
that referenced
this pull request
Aug 22, 2024
The Ruby repository cherry-picked mmtk/ruby#80 onto the dev/mmtk-overrides-default branch which will follow the official master branch. It added a CI scripts and excluded some tests using Ruby scripts in the `.excludes-mmtk/` directory. We add an option to `make test-all` to take the `.excludes-mmtk` directory into consideration. With this change, it should be, in theory, possible to selectively run tests runnable for MMTk without using the whitelist `ruby-test-cases.txt` in this repo. However, some test cases still crashes due to bugs in the binding. We'll still use the whitelist for running binding tests for the mmtk-core repo, until we fix those crashes so that `make test-all` can finish safely with MMTk enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a previously registered PPP is no longer a PPP when a GC starts, we don't pin its children, and we remove it from the list of PPPs. Currently only iseq is conditional PPP.