Update Ruby repo revision #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream made some changes to the root-scanning functions, notably,
- Introduced yjit roots.
- Seperated root-scanning into the GC-implementation-agnostic
rb_gc_mark_roots in gc.c and the GC-implementation-specific
mark_roots in gc/default.c.
In the `ruby` repo, we reorder the root-scanning functions in the upcall
table so that the general functions come before the
implementation-specific functions. Also added yjit roots as one upcall,
although its implementation is a no-op if yjit is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream made some changes to the root-scanning functions, notably,
rb_gc_mark_roots in gc.c and the GC-implementation-specific
mark_roots in gc/default.c.
In the
rubyrepo, we reorder the root-scanning functions in the upcall table so that the general functions come before the implementation-specific functions. Also added yjit roots as one upcall, although its implementation is a no-op if yjit is not enabled. See: mmtk/ruby#88