Rewrite conditional String code and add assertions in WB #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a feature to assert the source and the target objects are valid object references in write barriers. It is controlled by a macro so that it can be enabled in release build, too.
When the "#if USE_MMTK" directive and the `if (rb_mmtk_enabled_p())` statement are used together, it will be very complicated and confusing. We rewrite `string.c` using the convenient `WHEN_USING_MMTK`, `WHEN_NOT_USING_MMTK` and `WHEN_USING_MMTK2` macros when possible. This commit does not change the semantics of the existing code in `string.c`.
wks
merged commit cba8733
into
mmtk:dev/mmtk-overrides-default
105 of 113 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes.
Rewrote
string.cto use theWHEN_USING_MMTK,WHEN_NOT_USING_MMTKandWHEN_USING_MMTK2macros. It should make the code that depending on whether MMTk is used easier to read and maintain.Added the ability to do assertions in write barriers about whether the source and the target objects are valid references to MMTk objects. This will help catching dangling references as soon as they are written into object fields (if written using write barriers, which should be the common case anyway). The assertions are enabled using the
MMTK_WB_ASSERT_VOmacro. Note that tests will fail if we enable it now due to existing bugs.These changes makes preparation for fixing bugs related to strings, including #93