-
Notifications
You must be signed in to change notification settings - Fork 79
ENH: Allow multiple tasks to be processed jointly #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* upstream/main: Add support for MNE-ICALabel (mne-tools#1018) [pre-commit.ci] pre-commit autoupdate (mne-tools#1145) [dependabot]: Bump actions/download-artifact from 6 to 7 (mne-tools#1143) [dependabot]: Bump actions/upload-artifact from 5 to 6 (mne-tools#1142) [dependabot]: Bump actions/cache from 4 to 5 (mne-tools#1144)
|
Okay, I think OpenNeuro is having a bad day. But the datasets that can be downloaded work, and the multi-task support works on my dataset! @drammock do you want to review+merge now, or wait until we can get a suitable dataset for testing? |
|
I won't have time to review today, but I do have permission to use one subject from the PREK dataset (and I have the files), so maybe worth waiting for that. I hope to get to it early next week. |
|
Okay feel free to push commits directly to this PR. It'll be a good way to test it out! Or I can do it once the data are uploaded |
Before merging …
docs/source/dev.md.incepochs-basedcovsomehow... probably by making surebaselines are the same and compatible and if not, tell the user to use a custom function instead of"epochs"EnsureDropped in favor of existing ENH: Add mf_bads option #760preprocessing/*uses union of all bad channels across all tasks (including noise!):Just opening to make sure nothing is broken yet. It shouldn't be since this should just relax type def checks in a way that shouldn't matter, but 🤷
Closes #820