Skip to content

move set_eeg_montage after drop_channels#1220

Open
dnacombo wants to merge 2 commits intomne-tools:mainfrom
dnacombo:drop_before_import
Open

move set_eeg_montage after drop_channels#1220
dnacombo wants to merge 2 commits intomne-tools:mainfrom
dnacombo:drop_before_import

Conversation

@dnacombo
Copy link
Copy Markdown

@dnacombo dnacombo commented Apr 20, 2026

to match config statement:

# !!! warning
#     If the data contains channel names that are not part of the template montage, the
#     pipeline run will fail with an error message. You must either pick a different
#     montage or remove those channels via
#     [`drop_channels`][mne_bids_pipeline._config.drop_channels] to continue.

Before merging …

  • Changelog has been updated (docs/source/dev.md.inc)

@larsoner
Copy link
Copy Markdown
Member

Looks reasonable to me! Can you add a docs/source/dev.md.inc line about the change in the order of these operations? Or I can do it quickly if you'd prefer. I just want some note in there in case there are some unexpected results.

And I assume this fixes things for your dataset(s)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants