ENH: Improve possible dataset error discoverability#1225
Open
larsoner wants to merge 19 commits intomne-tools:mainfrom
Open
ENH: Improve possible dataset error discoverability#1225larsoner wants to merge 19 commits intomne-tools:mainfrom
larsoner wants to merge 19 commits intomne-tools:mainfrom
Conversation
Member
Author
|
Okay I think this is ready @drammock ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/dev.md.inc)Our default of
mne_log_level = "error"I think is unsafe -- it's too easy for users to hit likely errors in their datasets and not notice. So this PR:ignore_warningsconfig param to make it easy to choose warning messages to suppressread_raw_bids_verbose,mne_log_level, andlog_levelintoexec_params, which is the correct scope for them: they should not affect run caching (previously at leastread_raw_bids_verbosewould have) and outputs/results, just the messages that get printed to the consoleI think evidence for the utility is already here in this PR when combined with our tests treating warnings-as-errors:
ignore_warningsI ended up adding fords0001117-- you can see multiple issues with it as a BIDS dataset and/or our reading of it_07_make_epochs.py, where I needed a new_ignore_warningscontext (which caused me to have to think about whether or not it was appropriate/safe!)I suspect as all datasets run through I'll hit a lot more warnings for them and need to add
ignore_warningsto a number of them. But we'll see...