-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Axial to planar gradiometer transformation #13196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is based on the channel positions and orientations provided by fieldtrip: https://github.com/fieldtrip/fieldtrip/blob/master/template/gradiometer/ctf275.mat
This is based on the channel positions and orientations provided by fieldtrip: https://github.com/fieldtrip/fieldtrip/blob/master/template/gradiometer/neuromag306.mat
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
That way we can parse the txt files and select the channel type we want to interpolate to. For example we do not want to interpolate to the ch_type = 'ref' for the CTF.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Looks like you're making some progress, let me know when you'd like some feedback! |
Hi @larsoner! After a while, I finally found some time :) I think this is a good moment for some feedback. Issues / Questions I encountered: My initial understanding was that when we interpolate from CTF to Neuromag, the ch_type should already be known. This is because, CTF systems have reference sensors that should not be interpolated and Neuromag systems have gradiometers and magnetometers, so we need to know the type of each channel. That's why I added the ch_type parameter in the .txt montage files — to explicitly specify this. 2. Scope of interpolation: only gradiometers? Based on this, I thought I would input in 3. Limitations of make_dig_montage From the documentation of
I understood that for my setup (no fiducials) I should use a custom montage. However: running 4. Custom _meg() function and related problems But now I run into new problems. When I run
5. I added _meg() inside _standard_montage_utils but am I allowed to change such private function ? 6. I am trying to follow how interpolate_to() code style and structure is already built. However, this forces us to diverge a bit from the standard One idea I had would be to encapsulate some logic in a new function |
Reference issue (if any)
Fixes #9609 .
What does this implement/fix?
Additional information
The channel positions and orientations are adopted from fieldtrip: https://github.com/fieldtrip/fieldtrip/blob/master/template/gradiometer
I am not sure if for the interpolation we need the coil positions and orientations. For clarity: a gradiometer is ONE channel but has TWO coils. A magnetometer is ONE channel and has ONE coil.
As an expectation I have that I will plot ERPs in the ctf and neuromag format. Also I want to create topoplots like: https://www.fieldtriptoolbox.org/assets/img/tutorial/eventrelatedaveraging/figure8.png