-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve tests of maxwell_filter_prepare_emptyroom #13208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c95b69b
add doc
mscheltienne 6316363
explicitly exclude eeg-like channels
mscheltienne d8b3734
add channel selection and tests
mscheltienne 27ee081
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d0bb749
add changelog entry
mscheltienne e327bfd
Merge branch 'maxwellpepare' of https://github.com/mscheltienne/mne-p…
mscheltienne 4ecbece
fix typo
mscheltienne 36520e1
simpler fix and test
mscheltienne 89cd05f
revert
mscheltienne e6f70fb
add assert
mscheltienne 44055aa
Merge remote-tracking branch 'upstream/main' into maxwellpepare
mscheltienne 9f0184b
improve test
mscheltienne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Remove channels with potential electrode location from :func:`~mne.preprocessing.maxwell_filter_prepare_emptyroom`, by `Mathieu Scheltienne`_. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I think about it, the more I feel like it should simply be
.pick("meg", exclude=())
. I can't think of a reason to add those channels back.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding the EEG channels back, but regarding
.pick("meg", exclude=())
there are other channel types that you could reasonably want to have around (e.g., stim, CHPI status, active shield status, etc.) and it's hard to know every end-users use case / needs, hence the use of a blocklist approach (eeg-like) here rather than an allowlist (meg) approach.