Skip to content

MAINT: Restore VTK dev #13214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

MAINT: Restore VTK dev #13214

merged 2 commits into from
Apr 16, 2025

Conversation

larsoner
Copy link
Member

PyVista updated and should now work with latest vtk dev, so let's use it

@larsoner larsoner requested a review from drammock as a code owner April 15, 2025 13:28
@larsoner larsoner enabled auto-merge (squash) April 15, 2025 13:28
@larsoner
Copy link
Member Author

Needs pyvista/pyvista#7427, will restart failed CIs after it lands

@user27182
Copy link

FYI the issues with pyvista/vtk master include more than just import errors, there are issues with merge, and some plotting issues and a seg fault too. See pyvista/pyvista#7410 (comment)

Not sure how CI will fare here but there may still be failures caused by these other issues.

@larsoner larsoner merged commit a0dda10 into mne-tools:main Apr 16, 2025
30 checks passed
@larsoner larsoner deleted the cis branch April 16, 2025 17:11
larsoner added a commit to SYXiao2002/mne-python that referenced this pull request Apr 18, 2025
* upstream/main: (40 commits)
  fix typo (missing space) that messed up rst rendering (mne-tools#13217)
  MAINT: Restore VTK dev (mne-tools#13214)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13212)
  BUG: Fix bug with example (mne-tools#13210)
  MAINT: Fix pip-pre with PyVista (mne-tools#13207)
  Move FCBG to former partners (mne-tools#13205)
  ENH: Update related software list (mne-tools#13202)
  fix sfreq estimation for snirf files (mne-tools#13184)
  ENH: Use data-based padding instead of "odd" padding when filtering in raw.plot (mne-tools#13183)
  FIX: Bumps (mne-tools#13198)
  DOC: fix typo in examples/io/read_impedances.py (mne-tools#13197)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13173)
  FIX make_watershed_bem to handle missing talairach_with_skull.lta courtesy Freesurfer 8 (mne-tools#13172)
  ENH: Add upsampling for MEG helmet surface (mne-tools#13179)
  MAINT: Update code credit (mne-tools#13180)
  BUG: Fix bug with least-squares sphere fit (mne-tools#13178)
  fix EDF export (mne-tools#13174)
  fix typo (mne-tools#13171)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13164)
  Fix dev installation guide (mne-tools#13163)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants