Skip to content

Plot ica comparison #13215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Ganasekhar-gif
Copy link

@Ganasekhar-gif Ganasekhar-gif commented Apr 15, 2025

EOG Component Detection
Reference Issue:
Addresses #9002

What does this implement/fix?
This draft PR improves the ICA comparison example by:
Comparing multiple ICA algorithms: FastICA, Picard, Infomax, and Extended Infomax.
Evaluating performance on both clean and synthetically noisy MEG data.
Detecting and visualizing EOG-related components for each method.
Showing side-by-side component comparisons to enhance interpretability.
Displaying fit time per method for performance benchmarking.
Providing a more informative educational example (moving beyond just a "how-to").

Preview: Output Snapshots
Fastica method on clean data: https://github.com/user-attachments/assets/03fbe1d3-d8ad-4349-96fa-f6743e42ff88
Fastica method on noisy data: https://github.com/user-attachments/assets/59c86307-a9fe-4f2b-93d6-434f2131181e
EOG component comparison: https://github.com/user-attachments/assets/a670261b-a32a-4da0-a25c-d8332e3924db

Additional Information:
This is a work-in-progress PR as encouraged by the maintainers. I'm looking for early feedback on:
Visual clarity of EOG component comparisons.
Whether to include more deterministic checks (e.g., random_state).

In addition, I have a couple of questions:
EOG Component Comparison:
The issue refers to comparing EOG components. Currently, I've selected the most likely EOG-related component based on each ICA method's output. Could you clarify what “the same” EOG component refers to in this context? Are you expecting comparisons based on a specific pre-determined EOG component or should this focus on the component detected by each algorithm?

Summary of Changes:
Slightly reworded the description for clarity.
Structured the PR content with bullet points to improve readability.
Reworded the EOG component question to avoid confusion.

Ganasekhar-gif and others added 7 commits April 15, 2025 14:36
Added visualization plots for different ICA algorithms for clean and noisy data
added visualization plots for different ICA algorithms and added fit times for both clean and noisy data.
created 13215.enhancement.rst file
@Ganasekhar-gif Ganasekhar-gif marked this pull request as ready for review April 21, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant