-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Test Analytics #13225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test Analytics #13225
Conversation
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
.circleci/config.yml
Outdated
@@ -242,8 +242,10 @@ jobs: | |||
command: | | |||
if [[ $(cat gitlog.txt) == *"[circle front]"* ]] || [[ $(cat build.txt) == "html-memory" ]] ; then | |||
make test-doc; | |||
coverage run -m pytest --junitxml=test-results.xml; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to run pytest
here. Our test-doc
run is:
test-doc: sample_data testing_data
$(PYTESTS) --doctest-modules --doctest-ignore-import-errors --doctest-glob='*.rst' ./doc/ --ignore=./doc/auto_examples --ignore=./doc/auto_tutorials --ignore=./doc/_build --ignore=./doc/conf.py --ignore=doc/sphinxext --fulltrace
And we already produce a suitable junit.yml
I think... we probably just need to upload the one we already create
@katia-sentry let me know if you want me to push directly to adapt or if you want to iterate a bit. Feel free to add your name to |
for more information, see https://pre-commit.ci
@larsoner appreciate your review and feedback. I made the requested changes. Let me know if I missed anything, or more iteration is required. Thank you! |
95b1a2b
to
45ecfc4
Compare
for more information, see https://pre-commit.ci
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Thanks @katia-sentry ! |
Hey there! I work over at Sentry on the Codecov team and we've set a goal for adding some of our new features to open source repos already using Codecov. I saw this repo using Codecov, and it seemed like a good fit :)
What is the new features?
Test Analytics is a new Codecov feature providing insights into your test suite's health.
Looking forward to your feedback!