Skip to content

Annotations extras #13228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Jun 2, 2025
Merged

Annotations extras #13228

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
054ad12
Add check
PierreGtch Apr 24, 2025
ee92613
Add details attribute to annotations
PierreGtch Apr 24, 2025
fdceb5b
Update tests
PierreGtch Apr 24, 2025
a421357
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 24, 2025
078d837
fix coquille
PierreGtch Apr 24, 2025
68fb8b3
Update change log
PierreGtch Apr 24, 2025
33a35a5
Merge branch 'annotations-details' of https://github.com/PierreGtch/m…
PierreGtch Apr 24, 2025
ecac5e2
Make DetailsDict private and add docstring
PierreGtch Apr 24, 2025
ec34833
Fix test
PierreGtch Apr 25, 2025
7b1d70b
ise int_like instead of int
PierreGtch Apr 25, 2025
fe6e4a1
Apply suggestions from code review
PierreGtch Apr 26, 2025
9bcbc3f
Remove _check_forbidden_values
PierreGtch Apr 26, 2025
f8999b2
Remove _check_forbidden_values
PierreGtch Apr 26, 2025
e8f6728
Rename details to extras
PierreGtch Apr 26, 2025
09bb125
Fix _AnnotationsExtrasDict and add test
PierreGtch Apr 26, 2025
32641c0
fix writers
PierreGtch Apr 26, 2025
76da62a
Improve type description in docstrings
PierreGtch Apr 26, 2025
03e1b5a
only have a list of dict internally (no None)
PierreGtch Apr 26, 2025
dfa428f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 26, 2025
7730c2f
Update test
PierreGtch Apr 26, 2025
507d7f7
Merge branch 'annotations-details' of https://github.com/PierreGtch/m…
PierreGtch Apr 26, 2025
9b43610
Add missing docstring
PierreGtch Apr 26, 2025
09dd2af
Merge branch 'main' into annotations-details
PierreGtch Apr 26, 2025
dceb489
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 26, 2025
b2c89e9
Apply review suggestion
PierreGtch Apr 26, 2025
3f2003a
Fix tests
PierreGtch Apr 26, 2025
1d2b30c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 26, 2025
1b2b05d
Fix docstrings
PierreGtch Apr 27, 2025
a94dc4f
Apply suggestions from code review
PierreGtch May 1, 2025
ab0f067
Improve `test_extras_dict_raises`
PierreGtch May 1, 2025
af8add6
Make extras_columns private
PierreGtch May 1, 2025
f924623
Remove extras_data_frame attribute
PierreGtch May 1, 2025
088858d
Support saving to csv and txt
PierreGtch May 1, 2025
74a480a
simplify assert
PierreGtch May 1, 2025
2f5a04e
Simplify read txt
PierreGtch May 1, 2025
94c06a9
Merge branch 'main' into annotations-details
PierreGtch May 1, 2025
f2a6b76
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 1, 2025
061eb58
pre-commit
PierreGtch May 1, 2025
d948ca8
Add _AnnotationsExtrasList container
PierreGtch May 2, 2025
d5e823c
simplify read CSV
PierreGtch May 3, 2025
ad0baa0
Update test
PierreGtch May 3, 2025
9e55e70
Warn when writing heterogeneous csv extras
PierreGtch May 3, 2025
cd9f08f
Warn when writing heterogenous dtypes in txt
PierreGtch May 3, 2025
42447bc
test warnings
PierreGtch May 3, 2025
960a7c2
Fix annotations list repr
PierreGtch May 3, 2025
1e58564
Infer TXT types using pandas, if possible
PierreGtch May 3, 2025
28448ae
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 3, 2025
50f5385
Fix docstring format
PierreGtch May 3, 2025
77f35ba
Merge branch 'main' into annotations-details
PierreGtch May 3, 2025
cd716b9
Fix docstring format
PierreGtch May 3, 2025
ac07fa5
codespell
PierreGtch May 3, 2025
09b43ca
Remove unused function
PierreGtch May 3, 2025
445bf01
Skip mypy check
PierreGtch May 4, 2025
6de0f4c
Apply review suggestion (spelling)
PierreGtch May 9, 2025
3ea3a9a
Merge branch 'main' into annotations-details
larsoner May 21, 2025
9e67e3b
Apply suggestions from code review [circle full]
PierreGtch May 21, 2025
4acce8d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 21, 2025
3621595
[circle full]
drammock May 21, 2025
7406948
Fix positional arguments [circle full]
PierreGtch May 22, 2025
8af93a2
Add test for positional args
PierreGtch May 26, 2025
e7aa632
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 26, 2025
1668571
Add missing docstring
PierreGtch May 26, 2025
e908e89
Merge branch 'main' into annotations-details
PierreGtch May 26, 2025
efff25a
revert new test (unneeded)
drammock Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/13228.newfeature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a ``details`` attribute to :class:`mne.Annotations`, by `Pierre Guetschel`_.
1 change: 1 addition & 0 deletions doc/changes/names.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
.. _Peter Molfese: https://github.com/pmolfese
.. _Phillip Alday: https://palday.bitbucket.io
.. _Pierre Ablin: https://pierreablin.com
.. _Pierre Guetschel: https://github.com/PierreGtch
.. _Pierre-Antoine Bannier: https://github.com/PABannier
.. _Ping-Keng Jao: https://github.com/nafraw
.. _Proloy Das: https://github.com/proloyd
Expand Down
Loading
Loading