Skip to content

Improve error message for overwrite #13233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Improve error message for overwrite #13233

merged 4 commits into from
Apr 28, 2025

Conversation

sjentsch
Copy link
Contributor

Reference issue (if any)

Fixes #13230.

What does this implement/fix?

Provides an error message that makes more clear that data need to be preloaded if one wishes to overwrite files (save() with the parameter overwrite=True).

Copy link

welcome bot commented Apr 28, 2025

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

@larsoner
Copy link
Member

Can you add a little doc/changes/devel/13233.newfeature.rst with something like

Improved error message in :meth:`mne.io.Raw.save` when attempting to overwrite a file, by `Firstname Lastname`_

and then add your Firstname Lastname to doc/changes/names.inc?

Added myself as contributor of PR mne-tools#13233
@sjentsch
Copy link
Contributor Author

sjentsch commented Apr 28, 2025

Yup, sorry. I did this right now and will do in the future.

I assume I would have learned that from the contribution guidelines... I will better myself. ;-)

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking for merge-when-green, thanks @sjentsch !

@larsoner larsoner enabled auto-merge (squash) April 28, 2025 14:58
@larsoner larsoner merged commit 2bb3ac2 into mne-tools:main Apr 28, 2025
30 checks passed
Copy link

welcome bot commented Apr 28, 2025

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: save(): Error message is unclear
2 participants