Skip to content

Add a dev dependency group #13264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a dev dependency group #13264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
282cb09
Add a dev dependency group
cbrnr May 27, 2025
7228902
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
build-backend = "hatchling.build"
requires = ["hatch-vcs", "hatchling"]

[dependency-groups]
dev = [
"mne[dev]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe to really get everything one needs to do mne[full-pyside6,test-extra,dev] (or sub full-pyside6 for full to get PyQt6)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like with extras, we can add as many dependency groups as we like. I'd say that really everything should probably not be assigned to dev, but maybe dev-full or something like that. A more lightweight dev setup should probably also be supported by the test dependency group.

Regarding the warning on duplicate extras and dependency group names, uv does not have any issue with it. pip does not support dependency groups AFAIK, so we should be good.

"PySide6 != 6.7.0, != 6.8.0, != 6.8.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we have issues in interactivity with PySide6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but I'm happy to change it to PyQt6 if there are issues with PySide6. I added the latter because it is still the official Qt bindings package.

]

[project]
authors = [
{email = "[email protected]", name = "Alexandre Gramfort"},
Expand Down