Skip to content

Implement data skip in samples #13270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

papadop
Copy link
Contributor

@papadop papadop commented Jun 1, 2025

Reference issue (if any)

None

What does this implement/fix?

This implements the handling of the tag FIFF_DATA_SKIP_SAMP.
It does it by adding the handling of the tag in the reading loop.
Also, the implementation of the initial data skip is changed by leveraging the in-loop reading code instead of duplicating it as it was. In addition, the new code should handle correctly multiple FIFF_DATA_SKIP_SAMP or FIFF_DATA_SKIP, which was not the case previsouly.

Additional information

Fiff documentation states:

Data skip is a time segment where no data has been
measured. There are two ways of encoding a data skip. Currently only
only data_skip tag is supported, but any data reading routines should be
designed to handle also data_skip_samples tag. The difference is that
data_skip gives the length of the skip in number of data buffers whereas
data_skip_samples gives the length in samples.

This patch does it.
This is not a feature used that often, but since it is documented that way....

@larsoner
Copy link
Member

larsoner commented Jun 2, 2025

Do you have or could you create some tiny test file that has this attribute that we could add to mne-testing-data?

@papadop
Copy link
Contributor Author

papadop commented Jun 2, 2025

I will do that. Would a variant of intervalrecording_raw.fif be OK (at 12MB not sure it can be considered as tiny) ? If it is, I already have it, it will just remain to write the test down. Otherwise, I need to create a smaller one which would require a bit more time (but normally it shouldn't be too difficult).

@larsoner
Copy link
Member

larsoner commented Jun 2, 2025

Ideally < 1 MB would be better so if you can shrink it please do!

@papadop
Copy link
Contributor Author

papadop commented Jun 2, 2025

OK. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants