Enh UI event link#286
Conversation
|
@wmvanvliet @larsoner I'm picking this up again. I have the vertical bar synced across databrowsers and time browse and channel browse seem to be working. I haven't worked on edge cases yet. Wanted to get your opinions before I keep resuming more work |
Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
Resolve conflict: accept main directory restructure (mne_qt_browser/ -> src/mne_qt_browser/). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Integrate MNE ui_events system (TimeChange, TimeBrowse, ChannelsSelect) to enable syncing between multiple browser instances. Browsers can be linked via ui_events.link() to sync time position, time browsing, and channel selection. Includes proper cleanup on close and feedback loop prevention via disable_ui_events. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
my opinion on the matter is that it is a very cool feature, but indeed with lots of edge cases. This is especially true when you sync a raw-browser with an epochs-browser. We need a good testing suite. Perhaps we could build a list of tricky cases we can think of, so we can try all of those manually in the GUI. Also, please always declare how and where you use AI when working on this codebase. For example, That some commits are annotated with Claude is useful. |
|
great to hear to want to pick this up again! 🎉 |
2 participants
Reference issue
Example: Fixes #1234. , mne-tools/mne-python#12409 , #252
What does this implement/fix?
Adds
TimeChange,TimeBrowseandChannelBrowseui events to sync with ui event system.Additional information