Skip to content

Matrix - #2

Closed
mns-nordicals wants to merge 7 commits into
mainfrom
matrix
Closed

Matrix#2
mns-nordicals wants to merge 7 commits into
mainfrom
matrix

Conversation

@mns-nordicals

Copy link
Copy Markdown
Owner

Pull request to trigger github action build on multiple systems

@mns-nordicals

Copy link
Copy Markdown
Owner Author

@codex please review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

�ELF����>�@@(@8

[P1] Remove prebuilt native objects from src/

The commit adds quickr.so and quickr_dummy.o under src/. Shipping compiled artifacts in the package sources breaks portability: R CMD build/check will include these architecture-specific binaries in the tarball and can fail on platforms that cannot load or overwrite them. Source packages should contain only .c/.f and build scripts, allowing the build system to produce the binaries for the target platform. Please drop these files (or ignore them via .gitignore) so downstream builds remain clean.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@mns-nordicals
mns-nordicals deleted the matrix branch July 3, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant