Matrix - #2
Conversation
|
@codex please review |
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Line 1 in 0804188
[P1] Remove prebuilt native objects from
src/
The commit adds quickr.so and quickr_dummy.o under src/. Shipping compiled artifacts in the package sources breaks portability: R CMD build/check will include these architecture-specific binaries in the tarball and can fail on platforms that cannot load or overwrite them. Source packages should contain only .c/.f and build scripts, allowing the build system to produce the binaries for the target platform. Please drop these files (or ignore them via .gitignore) so downstream builds remain clean.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Pull request to trigger github action build on multiple systems