fix: prevent double Telegram polling loop on startup#62
Open
bluzername wants to merge 1 commit intomoazbuilds:masterfrom
Open
fix: prevent double Telegram polling loop on startup#62bluzername wants to merge 1 commit intomoazbuilds:masterfrom
bluzername wants to merge 1 commit intomoazbuilds:masterfrom
Conversation
Owner
|
I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The Telegram bot daemon opens two concurrent connections to
api.telegram.orgon startup, which causesgetUpdatesto return409 Conflicton every poll. Messages still work through retries but the logs are spammed with error messages nonstop.I had this happening on one of my agents and the logs were full of 409 errors which made it hard to see the real activity.
Root Cause
startPolling()insrc/commands/telegram.tshas no guard against being called twice. IfinitTelegram()is invoked twice before the firstpoll()enters itswhile (running)loop, two polling loops start concurrently - each opening its own TCP connection to Telegram API.Fix
Added an
isPollingflag that preventsstartPolling()from running more than once:The flag is also reset to
falsein the catch handler so if the first attempt fails completely, a retry can still work.This is the exact fix suggested in the issue. Simple, no side effects, covers the race condition.
Closes #47