fix(config): add missing discordUserIds param to parseSettings#64
Open
bladewing wants to merge 1 commit intomoazbuilds:masterfrom
Open
fix(config): add missing discordUserIds param to parseSettings#64bladewing wants to merge 1 commit intomoazbuilds:masterfrom
bladewing wants to merge 1 commit intomoazbuilds:masterfrom
Conversation
The parameter was removed from the signature in 58f6c4f but the function body and both callers still reference it, causing a ReferenceError crash on startup. Closes moazbuilds#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discordUserIds?: string[]parameter toparseSettings()insrc/config.tsReferenceError: discordUserIds is not definedcrash on daemon startupContext
Discord snowflake IDs exceed
Number.MAX_SAFE_INTEGER. TheextractDiscordUserIds()function extracts them as raw strings beforeJSON.parseloses precision. This parameter was accidentally removed in58f6c4f.Closes #63
Test plan
bun run src/index.ts start --webstarts without ReferenceError