Fix XBox shader compilation error#394
Open
emtony wants to merge 2 commits into
Open
Conversation
The UIEffect doesn't work correctly on XBox because the compiler doesn't like that cast. The error is: Shader error in 'Hidden/UI/Default (UIEffect)': Program 'frag', error: llvm::cast<X>() argument of incompatible type! (on gamecore_scarlett)
…t in a global variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UIEffect doesn't work correctly on XBox because the compiler doesn't like that it's using a global variable in the fragment shader. The error is:
Shader error in 'Hidden/UI/Default (UIEffect)': Program 'frag', error: llvm::cast<X>() argument of incompatible type! (on gamecore_scarlett)Type of change
I've removed the global variable in the fragment shader and now pass the color around in the function chain.
Test environment
Checklist
developbranch