Skip to content

Project creator 2.0#213

Merged
tischi merged 30 commits into
mobie:masterfrom
K-Meech:project_creator_2_0
Mar 15, 2021
Merged

Project creator 2.0#213
tischi merged 30 commits into
mobie:masterfrom
K-Meech:project_creator_2_0

Conversation

@K-Meech

@K-Meech K-Meech commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

Main changes:

  • adds correct downsampling for segmentations
  • splits export functionality from ExportImagePlusAsN5Plugin into a separate class: WriteImagePlusToN5
  • removes hdf5 support
  • changes default compression to gzip
  • larger string fields in project creator
  • Splits project creation into choosing a project name + project folder
  • handles spaces in filepath
  • refactored into more classes
  • various small fixes

Still WIP:

  • adding remote metadata

@K-Meech K-Meech marked this pull request as ready for review March 15, 2021 14:04
@K-Meech

K-Meech commented Mar 15, 2021

Copy link
Copy Markdown
Collaborator Author

Alright - I think this is ready to merge now!
In addition to changes above, it adds:

  • command for writing remote metadata to a project

@tischi - I changed XmlIoN5S3ImageLoader a bit, as the current toXml() wasn't giving the correct formatting

@tischi

tischi commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

I will merge it, but could you please locally first check whether it merges well with the current master from today (because I just merged changes from @constantinpape and maybe there could be conflicts...)

@K-Meech

K-Meech commented Mar 15, 2021

Copy link
Copy Markdown
Collaborator Author

I just checked - and all looks good!
I already made some changes to fit with @constantinpape (i.e. removing all the authentication fields)

@tischi tischi merged commit e5467c0 into mobie:master Mar 15, 2021
@tischi

tischi commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

You guys are faster then ⚡

@tischi

tischi commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Why is this PR still open? It is merged, isn't it?

@K-Meech

K-Meech commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator Author

It's merged! - but there's an old one: #184 that still needs to be closed

@K-Meech K-Meech deleted the project_creator_2_0 branch June 1, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants