Project creator 2.0#213
Merged
Merged
Conversation
Collaborator
Author
|
Alright - I think this is ready to merge now!
@tischi - I changed XmlIoN5S3ImageLoader a bit, as the current toXml() wasn't giving the correct formatting |
Contributor
|
I will merge it, but could you please locally first check whether it merges well with the current master from today (because I just merged changes from @constantinpape and maybe there could be conflicts...) |
Collaborator
Author
|
I just checked - and all looks good! |
Contributor
|
You guys are faster then ⚡ |
Contributor
|
Why is this PR still open? It is merged, isn't it? |
Collaborator
Author
|
It's merged! - but there's an old one: #184 that still needs to be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
Still WIP: