Keyboard shortcuts for the Annotator#384
Draft
tischi wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Ah ok - makes sense. Maybe you could just have 2 listeners (one on the annotator + one on the bdv window), to avoid the global listener? Not sure how hard this would be! |
Contributor
Author
|
Yes, something like this. I guess that's why it was never really implemented because I found this a bit tedious 😉 , but I will give it a 2nd shot! |
Contributor
Author
|
I asked in the forum: https://forum.image.sc/t/java-keyboard-listener-for-multiple-windows/55771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: #352
@K-Meech
I added back the code that was in the ij-utils commit. It turns out that this commit was just adding the button but did not implement the actual keyboard listener. I vaguely remember that I had trouble getting this to work, because the annotator typically is not the focused window, because people click in the BDV window. We could implement a "global" keyboard listener, but then if people write an e-mail in between it would still listen...