Allow configuring Android driver port#3344
Open
abaiadse wants to merge 1 commit into
Open
Conversation
Contributor
|
I note that the linked issue is a duplicate. Is there any chance that theres an existing PR for this too? (We're running a little behind, and they're piling up 😬) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added support for configuring the Android driver host port via the ANDROID_DRIVER_PORT environment variable.
Preserved the existing default behavior by continuing to use port 7001 when the environment variable is not set or contains an invalid value.
This allows users to avoid port conflicts and run multiple Maestro processes with custom port assignments.
Testing
Testing
Verified that Maestro continues to use port 7001 when ANDROID_DRIVER_PORT is not set.
Verified that setting ANDROID_DRIVER_PORT causes the Android driver to bind to the specified port.
Issues fixed
#3335