Add resilience to AddMedia command test#3352
Open
Fishbowler wants to merge 2 commits into
Open
Conversation
The media store might take time to add the image to the list, so include a retry.
Fishbowler
force-pushed
the
fix-media-test
branch
from
2cf6f6a to
37272ad
Compare
The command should flush its bytes immediately, rather than wait for the OS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media store might take time to add the image to the list, so include a retry.
I'd seen this test flake in a number of recent PRs, where no related code was included. I couldn't reproduce the flake locally, so device/runner performance is a factor too.
I intend to rerun the Android E2E a number of times to validate the fix.