test: stabilize iOS simulator UI tests - #387
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe iPhone simulator tests add reusable polling and tapping helpers for asynchronous UI interaction. Reminders navigation now handles multiple onboarding and confirmation states before opening a new reminder. Swipe, keyboard, Safari, Home screen, and Settings lifecycle tests wait for expected elements to appear or disappear instead of relying on fixed delays and single-shot screen snapshots. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/iphone-simulator.ts`:
- Around line 76-183: Add an explicit settle delay to both retry loops in
openNewReminder when no actionable state transition occurs: after the first loop
finds BackButton without Done, New Reminder, or the Reminders label, and after
tapping titleField in the second loop. Ensure retries wait for the UI to render
rather than immediately re-satisfying waitForElements, while preserving the
existing navigation and editor actions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d13e71cb-986e-474e-8eca-0b416c70ea00
📒 Files selected for processing (1)
test/iphone-simulator.ts
69c693b to
28da978
Compare
Replace fixed delays with condition-based UI polling and normalize stateful Reminders navigation before entering text. - wait for Settings, Safari, and Home screen readiness - dismiss Reminders onboarding and stale quick-entry state - verify keyboard and reminder transitions before continuing
Replace fixed delays with condition-based UI polling and normalize stateful Reminders navigation before entering text.