Skip to content

test: stabilize iOS simulator UI tests - #387

Open
wxxion wants to merge 1 commit into
mobile-next:mainfrom
wxxion:test-fix
Open

test: stabilize iOS simulator UI tests#387
wxxion wants to merge 1 commit into
mobile-next:mainfrom
wxxion:test-fix

Conversation

@wxxion

@wxxion wxxion commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Replace fixed delays with condition-based UI polling and normalize stateful Reminders navigation before entering text.

  • wait for Settings, Safari, and Home screen readiness
  • dismiss Reminders onboarding and stale quick-entry state
  • verify keyboard and reminder transitions before continuing

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b162e088-151c-4b75-bd74-554e3b0afb5b

📥 Commits

Reviewing files that changed from the base of the PR and between 28da978 and c8a5662.

📒 Files selected for processing (1)
  • test/iphone-simulator.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/iphone-simulator.ts

Walkthrough

The iPhone simulator tests add reusable polling and tapping helpers for asynchronous UI interaction. Reminders navigation now handles multiple onboarding and confirmation states before opening a new reminder. Swipe, keyboard, Safari, Home screen, and Settings lifecycle tests wait for expected elements to appear or disappear instead of relying on fixed delays and single-shot screen snapshots.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: stabilizing iOS simulator UI tests.
Description check ✅ Passed The description directly matches the changes by describing UI polling and Reminders navigation stabilization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/iphone-simulator.ts`:
- Around line 76-183: Add an explicit settle delay to both retry loops in
openNewReminder when no actionable state transition occurs: after the first loop
finds BackButton without Done, New Reminder, or the Reminders label, and after
tapping titleField in the second loop. Ensure retries wait for the UI to render
rather than immediately re-satisfying waitForElements, while preserving the
existing navigation and editor actions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d13e71cb-986e-474e-8eca-0b416c70ea00

📥 Commits

Reviewing files that changed from the base of the PR and between f084553 and a9f7ff2.

📒 Files selected for processing (1)
  • test/iphone-simulator.ts

Comment thread test/iphone-simulator.ts
@wxxion
wxxion force-pushed the test-fix branch 2 times, most recently from 69c693b to 28da978 Compare July 19, 2026 06:52
Replace fixed delays with condition-based UI polling and normalize stateful Reminders navigation before entering text.

- wait for Settings, Safari, and Home screen readiness
- dismiss Reminders onboarding and stale quick-entry state
- verify keyboard and reminder transitions before continuing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant