-
Notifications
You must be signed in to change notification settings - Fork 82
Added WebSocket Support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tbowers
wants to merge
16
commits into
mobile-web-messaging:master
Choose a base branch
from
tbowers:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use into SKRawSocket
…on (sending to queue working). Split out delegate to receive NSData (raw socket) or NSString (web socket
flag the project as no longer maintained
Corrected if (err) into if (error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this fork was to add web socket support. In doing so, I abstracted the raw socket usage under a common interface. I then added the RocketSocket web socket library and implemented the same interface. The strategy used is based on the host string provided (e.g. "ws://").
As part of my testing, I added a very basic single view iOS app to exercise the usage. It appears to be working fine at least with my AMQ server.
I don't believe I've done anything to regress the current library's functionality so I wanted to submit it back for possible merging. Otherwise, I'll continue to maintain my fork for WebSocket usage.