Open
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nick-mobilecoin and the rest of your teammates on |
nick-mobilecoin
commented
Nov 20, 2023
nick-mobilecoin
commented
Nov 20, 2023
eranrund
approved these changes
Nov 21, 2023
nick-mobilecoin
force-pushed
the
nick/timestamp-on-block
branch
from
84dd8db to
f618259
Compare
nick-mobilecoin
commented
Nov 21, 2023
nick-mobilecoin
commented
Nov 21, 2023
nick-mobilecoin
commented
Nov 21, 2023
nick-mobilecoin
force-pushed
the
nick/timestamp-on-block
branch
from
6a03791 to
c9eb8b8
Compare
nick-mobilecoin
commented
Nov 21, 2023
eranrund
approved these changes
Nov 21, 2023
The `Block` now has a `timestamp` field. This field is meant to represent a consensed timestamp for the block that all the nodes will sign. Currently the timestamp is *not* being populated. The logic to properly set the timestamp is expected to come in a follow on PR.
Previously one could set the `Block.timestamp` to something other than 0 when the block version didn't support timestamps. Now the timestamp will be set to 0 if the block version doesn't support timestamps
Currently the logic to populate the timestamp has not been implemented thus it's not practical to enforce the timestamp value at this time.
nick-mobilecoin
force-pushed
the
nick/timestamp-on-block
branch
from
881e5a9 to
55e6939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Blocknow has atimestampfield. This field is meant torepresent a consensed timestamp for the block that all the nodes will
sign.
Currently the timestamp is not being populated. The logic to properly
set the timestamp is expected to come in a follow on PR.