Skip to content

Generate tonic protos for api crates#4064

Open
nick-mobilecoin wants to merge 1 commit intorelease/v7.1from
nick/starting-tonic
Open

Generate tonic protos for api crates#4064
nick-mobilecoin wants to merge 1 commit intorelease/v7.1from
nick/starting-tonic

Conversation

@nick-mobilecoin
Copy link
Copy Markdown
Collaborator

@nick-mobilecoin nick-mobilecoin commented Sep 18, 2025

No description provided.

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
Comment thread Cargo.toml
Comment on lines +345 to +346
tonic = { version = "0.9", default-features = false }
tonic-build = "0.9"
Copy link
Copy Markdown
Collaborator Author

@nick-mobilecoin nick-mobilecoin Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.9 is the one that works with prost 0.11

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
Comment thread api/src/lib.rs
include!(concat!(env!("OUT_DIR"), "/protos-auto-gen/mod.rs"));
}

pub mod tonic {
Copy link
Copy Markdown
Collaborator Author

@nick-mobilecoin nick-mobilecoin Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure push these into a tonic namespace to avoid conflicting with the pub use crate::{autogenerated_code::* below

nick-mobilecoin
nick-mobilecoin commented Sep 18, 2025
View reviewed changes
Comment thread t3/api/src/lib.rs
Comment on lines +18 to +21
pub mod tonic {
pub mod external {
pub mod v1 {
tonic::include_proto!("external.v1");
Copy link
Copy Markdown
Collaborator Author

@nick-mobilecoin nick-mobilecoin Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure on this nesting here, may need to wait until the actual tonic implementations of gRPC is done

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 18, 2025

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 18, 2025

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 22, 2025

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 22, 2025

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eranrund eranrund eranrund approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nick-mobilecoin @eranrund