This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Open
Conversation
mboronin
force-pushed
the
bump-version
branch
from
f6d19e8 to
7f57f06
Compare
jgimenez
suggested changes
Feb 8, 2023
Member
jgimenez
left a comment
jgimenez
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution! I added just a simple comment but other than that, I think it's great to have this image updated :)
| && apt-get -yqq remove \ | ||
| && rm -rf "/opt/src/libreswan-${SWAN_VER}" | ||
|
|
||
| RUN apt-get -yqq remove \ |
Member
There was a problem hiding this comment.
Separating the cleanup phase into a different step makes the image larger. I would keep it in the same RUN statement.
Author
|
I'm still testing it actually, sorry for opening a PR too early. Trying to make the image a bit more slim, since there seem to be quite an increase in size after the upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggesting to update the dependencies to avoid vulnerabilities
Merge / Pull request information: