-
Notifications
You must be signed in to change notification settings - Fork 374
Large rewritting of docs #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great contribution thank you! We'll need some time to review this and may suggest to break into a few separate PRs but it looks like a big improvement on the current docs Is this now a duplicate of #712? If so please close one of them and we'll focus on the other |
|
I am not an active contributor or the codeowner, but definitely a great PR @a-alak |
Ahh sorry, my mistake. Seems like I accidentally pushed this change to #712 as well. #712 was mostly meant to be quick fixes to the current documentation to make it comply with websockets v15 and ocpp v2. This is more of rewrite of the documentation and structure. I will try to revert #712 to the originally changes for that PR. Might be a relevant bridge until this one is complete so we can avoid issues about version compatibility when people follow the current documentation. |
|
Thanks for the contributions @a-alak. Documentation, just like code, is a maintenance nightmare. Although I understand documenting important aspects of the functioning of the library, I think we should restrain ourselves from documenting everything. The codebase is built in a such way that it is quite easy to understand the workflow and pieces used just by looking at the code. Creating a documentation for such pieces is not preferred. E.g., Types of exceptions and their description. The Please don't take my suggestions as critical criticism but merely an improvement on your effort. Happy to point out what we should remove from documentation and what should be kept. |
|
Good point @jainmohit2001 ! I would then suggest to have some kind of overview of CSMS-initiated calls vs. Chargepoint-initiated calls referring to the actual data classes in this library. I know this is redundant when taking in to account the actual OCPP specification. However the specification can be hard to read and get an overview on. The main thing I did here was to rewrite the tutorials for implementing a CSMS and a Chargepoint, would love to hear your thoughts on that? Also what do you think about the suggestion of having sections explaining how to implement this library in different web frameworks? I often see questions regarding this and thought it could be nice to have it in the docs. Did not write any of it yet, but added it to the docs structure. |
Not ready for merge! This is a draft/suggestion. Would love your thoughts and feedback.
Changes included in this PR
First draft. Includes a restructuring of the docs setup, addition of multiple doc dependencies (sphinx_inline_tabs, myst_parser, sphinx_copybutton, furo theme), change of theme. Currently the biggest addition is tutorials. The API reference is mostly an AI created draft to get started. Includes suggestions on possible additions (how-to guides and topic guides).
Current behavior
There has been multiple request for updates/expansion of the documentation.
New behavior
Suggesting new documentation theme and a couple of extensions.
Impact
Only changes to the docs.
Checklist