Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solver: fix reading secrets from any session #5833

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

tonistiigi
Copy link
Member

The current logic was incorrect in some places so that if first session randomly chosen by Any() returned NotFound then other sessions were not attempted.

For the main use case of mounting secrets as files the logic was correct, but it was incorrect for example for the case of adding secrets as environment variables.

fix docker/buildx#3056

The current logic was incorrect in some places so that if first
session randomly chosen by `Any()` returned NotFound then other
sessions were not attempted.

For the main use case of mounting secrets as files the logic
was correct, but it was incorrect for example for the case of
adding secrets as environment variables.

Signed-off-by: Tonis Tiigi <[email protected]>
@crazy-max crazy-max merged commit 36b0458 into moby:master Mar 12, 2025
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bake secrets are ignored from transitive targets
2 participants