Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create cdi spec folders in buildkit container #5840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

BuildKit image does not have any CDI spec folders created so when running this container we have the following "CDI setup error" warnings:

time="2025-03-14T10:39:34Z" level=info msg="auto snapshotter: using overlayfs"
time="2025-03-14T10:39:34Z" level=warning msg="CDI setup error /etc/buildkit/cdi: failed to monitor for changes: no such file or directory"
time="2025-03-14T10:39:34Z" level=warning msg="CDI setup error /etc/cdi: failed to monitor for changes: no such file or directory"
time="2025-03-14T10:39:34Z" level=warning msg="CDI setup error /var/run/cdi: failed to monitor for changes: no such file or directory"
time="2025-03-14T10:39:34Z" level=warning msg="using host network as the default"
time="2025-03-14T10:39:34Z" level=info msg="found worker \"y0dyo8y35v6fohh1nepmgsnyz\", labels=map[org.mobyproject.buildkit.worker.executor:oci org.mobyproject.buildkit.worker.hostname:3d5bcf9351a9 org.mobyproject.buildkit.worker.network:host org.mobyproject.buildkit.worker.oci.process-mode:sandbox org.mobyproject.buildkit.worker.selinux.enabled:false org.mobyproject.buildkit.worker.snapshotter:overlayfs], platforms=[linux/amd64 linux/amd64/v2 linux/amd64/v3 linux/arm64 linux/riscv64 linux/ppc64le linux/s390x linux/386 linux/arm/v7 linux/arm/v6]"
time="2025-03-14T10:39:34Z" level=warning msg="skipping containerd worker, as \"/run/containerd/containerd.sock\" does not exist"
time="2025-03-14T10:39:34Z" level=info msg="found 1 workers, default=\"y0dyo8y35v6fohh1nepmgsnyz\""
time="2025-03-14T10:39:34Z" level=warning msg="currently, only the default worker can be used."
time="2025-03-14T10:39:34Z" level=info msg="running server on /run/buildkit/buildkitd.sock"

That means these folders are not monitored and therefore creating a CDI specification will not trigger a refresh of CDI devices.

Although if custom CDI specs dir is specified in buildkitd toml it will not work so keeping in draft for now. I think that should be done in Buildx repo when creating the container builder instead.

@tonistiigi
Copy link
Member

I think this is ok. We can bring it out of draft.

@crazy-max crazy-max marked this pull request as ready for review March 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants