fix metadata resp.Body leak #6313
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In (*httpSourceHandler).resolveMetadata method there is a potential resp.Body leak in case when response status code is not valid (< 200 or >= 400). Also resp.Body is not closed before exiting if status code is okay. This commit adds resp.Body closing before exiting from resolveMetadata method. Signed-off-by: Mikhail Dmitrichenko <[email protected]>
tonistiigi
reviewed
Oct 31, 2025
There was a problem hiding this comment.
was reading the docs for this
If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close. If the Body is not both read to EOF and closed, the Client's underlying RoundTripper (typically Transport) may not be able to re-use a persistent TCP connection to the server for a subsequent "keep-alive" request.
So it looks like we should not only close but also read to io.Discard. Not sure if it makes any difference in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In
(*httpSourceHandler).resolveMetadatamethod there is a potentialresp.Bodyleak in case when response status code is not valid (< 200 or >= 400). Alsoresp.Bodyis not closed before exiting if status code is okay.This PR adds resp.Body closing before exiting from
resolveMetadatamethod.