authprovider: make it possible to provide custom AuthConfig providers #6408
+114
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables client to provide their own functionality for AuthConfig lookup, rather than just passing in dockercli.ConfigFile. Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
reviewed
Dec 16, 2025
Comment on lines
25
to
27
| p := NewDockerAuthProvider(DockerAuthProviderConfig{ | ||
| ConfigFile: cfg, | ||
| AuthConfigProvider: LoadAuthConfig(cfg), | ||
| }).(*authProvider) |
Member
There was a problem hiding this comment.
Maybe not for this PR but maybe we could move the docker auth provider to another package like session/auth/authprovider/dockerconfig?
Member
Author
There was a problem hiding this comment.
Sure, I can do that in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables client to provide their own functionality for AuthConfig lookup, rather than just passing in dockercli.ConfigFile.
These are the buildkit client-side changes extracted from docker/buildx#3562 .