Skip to content

un-skip tests on Windows V19H1 (1903) and up #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 28, 2025

This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;

=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
    changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]

=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
    changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"

This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f. This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f

This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current
Windows versions. These tests were failing on Windows V19H1 (1903) and up,
possibly due to changes in the kernel, and were skipped in commit
8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f;

    === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
        changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]

    === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
        changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"

This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f.
This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9ec1e6e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   66.04%           
=======================================
  Files           ?       32           
  Lines           ?     2718           
  Branches        ?        0           
=======================================
  Hits            ?     1795           
  Misses          ?      744           
  Partials        ?      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
Copy link
Member Author

=== RUN   TestChangesDirsEmpty
    changes_test.go:260: Reported changes for identical dirs: [{\dirSymlink C}]
--- FAIL: TestChangesDirsEmpty (0.06s)
=== RUN   TestChangesDirsMutated
    changes_test.go:392: unexpected change "C \\dirSymlink" "\\dirnew"
--- FAIL: TestChangesDirsMutated (0.06s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants