fix linting issues #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had some other changes, but need to make sure we have CI running in this repository first. |
thaJeztah
commented
Apr 14, 2025
changes_test.go
Outdated
Comment on lines
197
to
198
| dir3 := path.Join(baseLayer, "dir1/dir2/dir3") | ||
| os.MkdirAll(dir3, 0o7400) | ||
| assert.NilError(t, os.MkdirAll(dir3, 0o7400)) |
There was a problem hiding this comment.
Interesting; so this is failing;
=== RUN TestChangesWithChangesGH13590
changes_test.go:198: assertion failed: error is not nil: mkdir /tmp/docker-changes-test.2086521634/dir1/dir2: permission denied
--- FAIL: TestChangesWithChangesGH13590 (0.00s)
There was a problem hiding this comment.
Ooooh! Look at that;
os.MkdirAll(dir3, 0o7400)
Extra trailing zero???
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
fix "struct literal uses unkeyed fields" (govet), and rename a function
to prevent shadowing.
pkg/archive/changes_test.go:123:18: composites: github.com/docker/docker/pkg/archive.Change struct literal uses unkeyed fields (govet)
modifyChange := Change{"change", ChangeModify}
^
pkg/archive/changes_test.go:128:15: composites: github.com/docker/docker/pkg/archive.Change struct literal uses unkeyed fields (govet)
addChange := Change{"change", ChangeAdd}
^
...
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Error: archive.go:1138:8: comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
if err == io.ErrClosedPipe {
^
Error: archive.go:1495:46: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pipeW.CloseWithError(fmt.Errorf("%s: %s", err, errBuf.String()))
^
Error: changes_test.go:37:20: type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
if exiterr, ok := err.(*exec.ExitError); ok {
^
Error: copy_unix_test.go:358:5: comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
if err != ErrDirNotExists {
^
Error: copy_unix_test.go:367:5: comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
if err != ErrDirNotExists {
^
Error: diff.go:226:63: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return true, fmt.Errorf("failed to decompress archive: %v", err)
^
Error: diff.go:235:70: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return false, fmt.Errorf("failed to read next archive header: %v", err)
^
Error: utils_test.go:78:15: type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
if _, ok := err.(breakoutError); !ok {
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
@dmcgowan ptal 🤗 |
Error: archive.go:347:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("Unsupported compression format %s", (&compression).Extension())
^
Error: archive.go:367:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("Unsupported compression format %s", (&compression).Extension())
^
Error: archive.go:369:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("Unsupported compression format %s", (&compression).Extension())
^
Error: internal/mounttree/switchroot_linux.go:29:55: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return fmt.Errorf("Error setting up pivot dir: %v", err)
^
Error: internal/mounttree/switchroot_linux.go:48:65: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
errCleanup = fmt.Errorf("Error cleaning up after pivot: %v", errCleanup)
^
Error: internal/mounttree/switchroot_linux.go:58:66: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
return fmt.Errorf("Error cleaning up after failed pivot: %v", err)
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
chrootarchive/archive_test.go:105:29: prepareSourceDirectory - numberOfFiles always receives 10 (unparam)
func prepareSourceDirectory(numberOfFiles int, targetPath string, makeSymLinks bool) (int, error) {
^
chrootarchive/archive_test.go:105:68: prepareSourceDirectory - result 0 (int) is never used (unparam)
func prepareSourceDirectory(targetPath string, makeSymLinks bool) (int, error) {
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
archive.go:1034:19: Error return value of `filepath.WalkDir` is not checked (errcheck)
filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Error: changes_linux.go:136:3: QF1006: could lift into loop condition (staticcheck)
if ix1 >= len(names1) {
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
dmcgowan
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "struct literal uses unkeyed fields" (govet), and rename a function to prevent shadowing.