ci: add golangci-lint

[thaJeztah]

No description provided.

[thaJeztah]

Something odd; gofumpt is failing on Windows, but can't spot anything wrong. Maybe some issue with the Windows build of it?

Error: archive.go:1:1: File is not properly formatted (gofumpt)
// Package archive provides helper functions for dealing with archive files.
^
Error: archive_other.go:1:1: File is not properly formatted (gofumpt)
//go:build !linux
^
Error: archive_windows.go:1:1: File is not properly formatted (gofumpt)
package archive
^

[thaJeztah]

Ugh, so gofmt is also complaining? I don't see what's wrong though 🤔

  Error: archive.go:1:1: File is not properly formatted (gofmt)
  // Package archive provides helper functions for dealing with archive files.
  ^
  Error: archive_other.go:1:1: File is not properly formatted (gofmt)
  //go:build !linux
  ^
  Error: archive_windows.go:1:1: File is not properly formatted (gofmt)
  package archive
  ^

[thaJeztah]

No idea; it seems to barf on every file it found; could it be a newlines issue?

Running [D:\a\_temp\a6315ed3-9a44-4157-9fee-e2f20c2bf47b\golangci-lint-2.1.1-windows-amd64\golangci-lint config path] in [D:\a\go-archive\go-archive] ...
  Running [D:\a\_temp\a6315ed3-9a44-4157-9fee-e2f20c2bf47b\golangci-lint-2.1.1-windows-amd64\golangci-lint config verify] in [D:\a\go-archive\go-archive] ...
  Running [D:\a\_temp\a6315ed3-9a44-4157-9fee-e2f20c2bf47b\golangci-lint-2.1.1-windows-amd64\golangci-lint run  --print-resources-usage --timeout=10m --verbose] in [D:\a\go-archive\go-archive] ...
  Error: archive.go:1:1: File is not properly formatted (gofumpt)
  // Package archive provides helper functions for dealing with archive files.
  ^
  Error: archive_other.go:1:1: File is not properly formatted (gofumpt)
  //go:build !linux
  ^
  Error: archive_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: archive_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: archive_windows_test.go:1:1: File is not properly formatted (gofumpt)
  //go:build windows
  ^
  Error: changes.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: changes_other.go:1:1: File is not properly formatted (gofumpt)
  //go:build !linux
  ^
  Error: changes_posix_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: changes_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: changes_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: chrootarchive\archive.go:1:1: File is not properly formatted (gofumpt)
  package chrootarchive
  ^
  Error: chrootarchive\archive_test.go:1:1: File is not properly formatted (gofumpt)
  package chrootarchive
  ^
  Error: chrootarchive\archive_windows.go:1:1: File is not properly formatted (gofumpt)
  package chrootarchive
  ^
  Error: chrootarchive\diff.go:1:1: File is not properly formatted (gofumpt)
  package chrootarchive
  ^
  Error: chrootarchive\diff_windows.go:1:1: File is not properly formatted (gofumpt)
  package chrootarchive
  ^
  Error: copy.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: copy_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: diff.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: diff_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: diff_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: fuzz_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: path.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: path_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: path_windows_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: time.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: time_windows.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: utils_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: whiteouts.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: wrap.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: wrap_test.go:1:1: File is not properly formatted (gofumpt)
  package archive
  ^
  Error: xattr_unsupported.go:1:1: File is not properly formatted (gofumpt)
  //go:build !linux && !darwin && !freebsd && !netbsd
  ^
  31 issues:
  * gofumpt: 31
  level=info msg="golangci-lint has version 2.1.1 built with go1.24.2 from 93dabf90 on 2025-04-12T18:19:05Z"

[thaJeztah]

could it be a newlines issue?

Narrator: it was! I added a .gitattributes to force lf line-endings, and now it's happy

[thaJeztah]

@vvoland ptal 🤗