move compression to a separate package #7
+686
−612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
move_compression
branch
3 times, most recently
from
c77f9a7 to
101e3d1
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
"Uncompressed" is 0, and the default value. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_compression
branch
3 times, most recently
from
4c9b11f to
02385ef
Compare
thaJeztah
force-pushed
the
move_compression
branch
from
02385ef to
e1662e1
Compare
thaJeztah
commented
Apr 15, 2025
compression/compression.go
Outdated
| type Compression int | ||
|
|
||
| const ( | ||
| Uncompressed Compression = 0 // Uncompressed represents the uncompressed. |
There was a problem hiding this comment.
This could be None instead of Uncompressed as suggested in moby/moby#49167 (comment)
I kept it to align with containerd, but TBD I guess?
There was a problem hiding this comment.
Not really a blocker for me, but I would be much more in favor of None (compression.None instead of compression.Uncompressed) 😅
There was a problem hiding this comment.
OK; done!
I also swapped the order of commits, doing the test-table changes first (before the move)
vvoland
approved these changes
Apr 15, 2025
compression/compression.go
Outdated
| type Compression int | ||
|
|
||
| const ( | ||
| Uncompressed Compression = 0 // Uncompressed represents the uncompressed. |
There was a problem hiding this comment.
Not really a blocker for me, but I would be much more in favor of None (compression.None instead of compression.Uncompressed) 😅
Signed-off-by: Sebastiaan van Stijn <[email protected]>
TODO: align with containerd pkg/archive/compression, which - also moved the utilities to Compress/Decompress streams - changed the Extension to not include ".tar" Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_compression
branch
from
e023a70 to
570d1cb
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's only used in tests now, so move it there. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_compression
branch
from
570d1cb to
b19a81b
Compare
|
@vvoland PTAL - looks like branch protection on this repo requires "re-approval" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.