Skip to content

Make Undo/Redo usable #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mocabe wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Make Undo/Redo usable #51

mocabe wants to merge 1 commit into from

Conversation

@mocabe
Copy link
Owner

@mocabe mocabe commented Jul 10, 2020 •
edited
Loading

Enable undo/redo feature

  • Ctrl + Z for undo
  • Ctrl + R for redo

Known issues:

  • Some operations are missing undo implementation
    • Ungrouping is not implemented in node library yet
  • Redo does not work on connect() operation
    • We need to support creating nodes and connections with custom ID, which is not really that hard I guess.
  • Undo for deletion of node group can be complex since it can contain sub-groups.
  • How do we restore default input values? Just store values in command history (which can take some memory)?
  • Should we capture node/socket changes, select, move?

@mocabe mocabe added the feature New feature label Jul 10, 2020
@mocabe mocabe marked this pull request as draft December 11, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mocabe