feat(evm): migrate payment precompile to native runtime base#340
Merged
Conversation
Move the payment precompile onto x/evm/precompiles/base, identical shape to the storage/storageprovider migrations: - embed base.Precompile; Run delegates to RunPrecompile; dispatch moves to Execute (existing handler map + base Dispatch/SetupABI, IsTransaction = !method.IsConstant()) - drop the hand-rolled cache-context / snapshot / commit template Runtime alignment only: EOA-only guards and per-handler readonly checks are kept; no balance handler wired. The package has no precompile tests; this relies on the shared base runtime already validated by bank/storage/ storageprovider plus the full precompile package sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part of subtask 3 (storage-series). Migrates the payment precompile onto
x/evm/precompiles/base, identical shape to storage #339 / storageprovider #338.Changes
Contractembedsbase.Precompile;Run→RunPrecompile; dispatch moves toExecute(existing handler map + baseDispatch/SetupABI,IsTransaction = !method.IsConstant()).Tests
The payment package has no precompile tests. This migration is byte-for-byte the same transformation validated for bank/storage/storageprovider, and relies on the shared base runtime plus the full precompile package sweep (
go test ./x/evm/precompiles/...). Flagging the lack of package-level coverage for reviewer awareness.go build ./...→ ok;golangci-lint→ 0 issues.precompile-integration.