feat(app): scaffold precompile direct-caller chain upgrade#345
Closed
phenix3443 wants to merge 1 commit into
Closed
feat(app): scaffold precompile direct-caller chain upgrade#345phenix3443 wants to merge 1 commit into
phenix3443 wants to merge 1 commit into
Conversation
Add the v2.1.0-precompile-direct-caller upgrade handler and integrator migration notes for activating the direct-caller precompile semantics (removal of EOA-only, contract callers allowed). This is a SCAFFOLD only: the precompile-side gating (making the EOA-only guard conditional on the upgrade) is a pending design decision documented in upgrades.PrecompileDirectCaller (on-chain param flag vs height gate). The handler currently only runs standard module migrations; it performs no direct-caller state change until the gating mechanism is chosen. - app/upgrades/precompile_direct_caller.go: handler + rationale + delivery checklist - app/app.go: register the handler - app/upgrades/PRECOMPILE_DIRECT_CALLER.md: SDK/CLI/contract-integrator notes
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtask 8. Scaffold only — pairs with the direct-caller change (#344, also held). Opened for review.
What
app/upgrades/precompile_direct_caller.go— thev2.1.0-precompile-direct-callerupgrade handler, with rationale, the pending gating-mechanism decision, and a delivery checklist.app/app.go— registers the handler.app/upgrades/PRECOMPILE_DIRECT_CALLER.md— SDK / CLI / contract-integrator migration notes.What it does NOT do (by design)
MsgSoftwareUpgrade, and testnet fork/replay are chain-ops steps (see the checklist).Tests
go build ./...→ ok;go vet ./app/upgrades/clean;golangci-lint→ 0 issues.precompile-integration.Next decision (yours)
Pick the gating mechanism (param flag recommended); then #344 is reworked to gate on it, and this handler flips it at the upgrade height.