chore: move callback and object typedefs to a new types.d.ts #5351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Creates a new
lib/types.d.ts
and moves every@callback
and@typedef {Object}
to it. A newtsconfig.json
&tsc
script can be run to verify that the types in that file can be type checked.Does not yet validate types in
.js
files (#4154, #4228). You can preview those by switchingtsconfig.json
'sallowJs
tocheckJs
. I made sure there are no more "Cannot find name ...
" errors but fixing the rest of the ~650+ will be a lot more work. Much of the code will be much easier to get type-safe when it's ported from manual function prototypes to classes (#5025). I also held off porting all the info from@types/mocha
there to keep the changes minimal.Does not yet try to pull in types or descriptions from
@types/mocha
. That would be a bigger change too.Moves error constants from
errors.js
toerror-constants.js
to avoid circular dependency errors.