Skip to content

fix(deps): update escape-string-regexp to v5 with ESM interop#5755

Closed
Copilot wants to merge 4 commits intorenovate/escape-string-regexp-5.xfrom
copilot/sub-pr-5746
Closed

fix(deps): update escape-string-regexp to v5 with ESM interop#5755
Copilot wants to merge 4 commits intorenovate/escape-string-regexp-5.xfrom
copilot/sub-pr-5746

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

  • Revert unnecessary changes (.github/workflows/mocha.yml and MAINTAINERS.md) to match main
  • Keep only necessary changes:
    • package.json: escape-string-regexp ^4.0.0 → ^5.0.0
    • lib/mocha.js: ESM interop (.default fallback) for escape-string-regexp v5
    • lib/reporters/html.js: ESM interop (.default fallback) for escape-string-regexp v5
    • package-lock.json: regenerated with npm@10.8.2 (Node 20)
  • Tests pass: smoke, unit (1059 passing)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 21, 2026

CLA Not Signed

…ttern

Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dependency issue by updating escape-string-regexp to v5 fix(deps): update escape-string-regexp to v5 with ESM interop Feb 21, 2026
Copilot AI requested a review from mark-wiemer February 21, 2026 03:24
@mark-wiemer
Copy link
Member

@copilot change this PR to merge into main, always use npm 10

…nterop

Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 21, 2026

@copilot change this PR to merge into main, always use npm 10

Done in commit 01bc9cd. Merged with the latest main (resolving conflicts to take main's changes while keeping escape-string-regexp: "^5.0.0" and the ESM interop fixes). The package-lock.json was regenerated with npm@10.8.2 (from Node 20). You'll need to update the PR base branch to main on GitHub — I'm unable to change the PR target directly.

@mark-wiemer
Copy link
Member

@copilot target main branch, use npm 10, and revert any unnecessary changes

…date

Co-authored-by: mark-wiemer <7833360+mark-wiemer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 21, 2026

@copilot target main branch, use npm 10, and revert any unnecessary changes

Done in commit 761ee62. The branch now only differs from main in exactly 4 files:

  • package.json: escape-string-regexp bumped from ^4.0.0 to ^5.0.0
  • lib/mocha.js + lib/reporters/html.js: ESM interop pattern for the v5 update
  • package-lock.json: regenerated with npm@10.8.2

All other files (.github/workflows/mocha.yml, MAINTAINERS.md, etc.) now match main. You'll still need to update the PR's target branch to main via the GitHub UI — that's not something I can do directly.

@mark-wiemer
Copy link
Member

closing, gonna do these manually one at a time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants